New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set initial reader count on TFChunk #1522

Merged
merged 1 commit into from Dec 18, 2017

Conversation

2 participants
@hayley-jean
Contributor

hayley-jean commented Dec 18, 2017

Adds an option, chunk-initial-reader-count to allow the user to set the initial number of readers to open per TFChunk.
By default, 5 readers are opened initially per chunk. If this is on a large database with old chunks that may never be read, this can cause many unnecessary file streams to be open at startup.

Also changes the test helper, TFChunkDbConfigHelper, to just TFChunkHelper and includes a constructor for creating a new chunk.
This makes updating the constructors for TFChunk and TFChunkDb much easier, as most of the code using these constructors belonged to tests.

@shaan1337 shaan1337 merged commit c05437a into release-v4.0.4 Dec 18, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
wercker/build-mono4 Wercker pipeline passed
Details

@hayley-jean hayley-jean deleted the initial-chunk-reader-count branch Dec 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment