New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FailOnNoServerResponse Fix #1769

Merged
merged 1 commit into from Dec 14, 2018

Conversation

2 participants
@riccardone
Copy link
Member

riccardone commented Nov 14, 2018

FailOnNoServerResponse does not fail on no server response
Fixes #1767

The CheckTimeoutsAndRetry method was not invoked during reconnection

To test this, set the FailOnNoServerResponse=true on the client side and try to connect or reconnect to a non working EventStore

Fix for the following Issue
FailOnNoServerResponse does not fail on no server response
#1767

The CheckTimeoutsAndRetry method was not invoked during reconnection

@riccardone riccardone changed the title Fix for FailOnNoServerResponse option FailOnNoServerResponse Fix Nov 20, 2018

@riccardone riccardone requested review from Lougarou and avish0694 and removed request for Lougarou Nov 26, 2018

@avish0694
Copy link
Member

avish0694 left a comment

Looks good.

@riccardone riccardone merged commit 92b3510 into EventStore:master Dec 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment