New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a maximum index level for automatically merging ptables #1842

Merged
merged 1 commit into from Jan 28, 2019

Conversation

3 participants
@jageall
Copy link
Collaborator

jageall commented Jan 28, 2019

  • Adds a startup option to set the maximum auto merge level
    which defaults to int.MaxValue to keep the current behavior
    of automerging all levels (after this, the list would break
    anyway)
  • Changes the indexmap to store the maximum automerge level
    reducing the automerge level is supported, but increasing
    it requires an index rebuild and will throw an exception
  • Adds an endpoint to trigger a manual merge via an http post
  • Manual merge will merge all the current ptables at the maximum
    automerge level

Signed-off-by: James Geall jageall@gmail.com

@jageall jageall requested review from jen20 and shaan1337 Jan 28, 2019

@jageall jageall force-pushed the trigger-indexmerge-with-maxAutomaticMerge branch from db8b655 to b124ea8 Jan 28, 2019

@jen20
Copy link
Member

jen20 left a comment

This looks good, with a few minor questions mostly around comments etc

Show resolved Hide resolved src/EventStore.Core/Index/IndexMap.cs Outdated
Show resolved Hide resolved src/EventStore.Core/Index/IndexMap.cs Outdated
Show resolved Hide resolved src/EventStore.Core/Index/TableIndex.cs Outdated
Show resolved Hide resolved src/EventStore.Core/Index/TableIndex.cs
Adds a maximum index level for automatically merging ptables
  - Adds a startup option to set the maximum auto merge level
    which defaults to int.MaxValue to keep the current behavior
    of automerging all levels (after this, the list would break
    anyway)
  - Changes the indexmap to store the maximum automerge level
    reducing the automerge level is supported, but increasing
    it requires an index rebuild and will throw an exception
  - Adds an endpoint to trigger a manual merge via an http post
  - Manual merge will merge all the current ptables at the maximum
    automerge level

Signed-off-by: James Geall <jageall@gmail.com>

@jageall jageall force-pushed the trigger-indexmerge-with-maxAutomaticMerge branch from b124ea8 to a65a109 Jan 28, 2019

@jen20

jen20 approved these changes Jan 28, 2019

@jen20 jen20 merged commit f25424d into master Jan 28, 2019

@jen20 jen20 deleted the trigger-indexmerge-with-maxAutomaticMerge branch Jan 28, 2019

@ChrisChinchilla

This comment has been minimized.

Copy link
Member

ChrisChinchilla commented Jan 30, 2019

@jageall and @jen20 Does this need docs changes?

@jen20

This comment has been minimized.

Copy link
Member

jen20 commented Jan 30, 2019

@ChrisChinchilla It will want a section about it - probably best to collaborate with @jageall on how to explain this feature.

@ChrisChinchilla

This comment has been minimized.

Copy link
Member

ChrisChinchilla commented Feb 19, 2019

@jageall Can you give me a quick summary of the effect of the changes? Looking through code I also think I'll add some more code documentation might be useful for the autogenerated code docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment