Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry reading from $users-password-notifications stream if the read times out #1919

Merged
merged 1 commit into from Apr 30, 2019

Conversation

3 participants
@shaan1337
Copy link
Member

commented Apr 29, 2019

If a read to $users-password-notifications is dropped by the StorageReaderWorker because it has expired, the PasswordChangeNotificationReader stops working and a node restart is required.

This prevents password updates, group changes, enabling/disabling/deleting users from taking effect on the node until it has been restarted.

The following message will be printed in the logs:

Read Stream Events Forward operation has expired for Stream: $users-password-notifications, From Event Number: <event number>, Max Count: 100. Operation Expired at <date>

Resolution
Re-read the stream after 10 seconds in the IO dispatcher timeout handler

@shaan1337 shaan1337 requested a review from avish0694 Apr 29, 2019

@jen20

jen20 approved these changes Apr 29, 2019

@jageall jageall merged commit dd41fa3 into master Apr 30, 2019

9 checks passed

EventStore.EventStore Build #20190429.1 succeeded
Details
EventStore.EventStore (Centos 7 x64 Debug) Centos 7 x64 Debug succeeded
Details
EventStore.EventStore (Centos 7 x64 Release) Centos 7 x64 Release succeeded
Details
EventStore.EventStore (Ubuntu 14.04 x64 Debug) Ubuntu 14.04 x64 Debug succeeded
Details
EventStore.EventStore (Ubuntu 14.04 x64 Release) Ubuntu 14.04 x64 Release succeeded
Details
EventStore.EventStore (Windows x64 Debug) Windows x64 Debug succeeded
Details
EventStore.EventStore (Windows x64 Release) Windows x64 Release succeeded
Details
EventStore.EventStore (macOS x64 Debug) macOS x64 Debug succeeded
Details
EventStore.EventStore (macOS x64 Release) macOS x64 Release succeeded
Details

@jageall jageall deleted the fix-password-change-reader branch Apr 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.