Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client subscription partition tolerance #1936

Merged
merged 3 commits into from May 28, 2019

Conversation

@condron
Copy link
Contributor

commented May 28, 2019

Correct 2 issues that seem to have the most significat effect on client connections with intermitted client connectivity issues.

On reconnect the Dropped data and Dropped flag are not always reset leading to race conditions that will fail to process a subsequent drop event corrrectly

There is a race condition where if a dropped connection resets the catchup subscription might not be cleaned up correctly.

@condron condron requested review from jageall and jen20 May 28, 2019

@condron condron added the kind/bug label May 28, 2019

@condron condron merged commit be8db04 into master May 28, 2019

9 checks passed

EventStore.EventStore Build #20190528.2 succeeded
Details
EventStore.EventStore (Centos 7 x64 Debug) Centos 7 x64 Debug succeeded
Details
EventStore.EventStore (Centos 7 x64 Release) Centos 7 x64 Release succeeded
Details
EventStore.EventStore (Ubuntu 14.04 x64 Debug) Ubuntu 14.04 x64 Debug succeeded
Details
EventStore.EventStore (Ubuntu 14.04 x64 Release) Ubuntu 14.04 x64 Release succeeded
Details
EventStore.EventStore (Windows x64 Debug) Windows x64 Debug succeeded
Details
EventStore.EventStore (Windows x64 Release) Windows x64 Release succeeded
Details
EventStore.EventStore (macOS x64 Debug) macOS x64 Debug succeeded
Details
EventStore.EventStore (macOS x64 Release) macOS x64 Release succeeded
Details

@condron condron deleted the client-subscription-partition-tolerance branch May 28, 2019

@avish0694 avish0694 restored the client-subscription-partition-tolerance branch May 29, 2019

@avish0694 avish0694 deleted the client-subscription-partition-tolerance branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.