Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BufferManager does not release acquired buffers #218

Merged
merged 1 commit into from Sep 14, 2014

Conversation

MariuszTrybus
Copy link
Contributor

BufferManager should release acquired buffers when it can't satisfy size requirement

@gregoryyoung
Copy link
Contributor

Upon review the change looks good but the exception for trials seems odd.
Either way good catch. Cheers, Greg

On Sun, Sep 14, 2014 at 11:33 PM, MariuszTrybus notifications@github.com
wrote:

BufferManager should release acquired buffers when it can't satisfy size

requirement

You can merge this Pull Request by running

git pull https://github.com/MariuszTrybus/EventStore buffermanager_checkout

Or view, comment on, or merge it at:

#218
Commit Summary

  • BufferManager should release acquired buffers when it can't satisfy
    size requirement

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#218.

Studying for the Turing test

gregoryyoung added a commit that referenced this pull request Sep 14, 2014
BufferManager does not release acquired buffers
@gregoryyoung gregoryyoung merged commit 1b9ca37 into EventStore:dev Sep 14, 2014
@gregoryyoung
Copy link
Contributor

Can you push the same commit to https://github.com/EventStore/buffer-manager ?

@MariuszTrybus
Copy link
Contributor Author

I've created pull request:
EventStore/buffer-manager#1

@gregoryyoung
Copy link
Contributor

Done. Thanks!

On Mon, Sep 15, 2014 at 4:55 PM, MariuszTrybus notifications@github.com
wrote:

I've created pull request:
EventStore/buffer-manager#1
EventStore/buffer-manager#1


Reply to this email directly or view it on GitHub
#218 (comment).

Studying for the Turing test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants