Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace hardcoded dash with _separator #41

Closed
wants to merge 1 commit into from

Conversation

johlrich
Copy link

@johlrich johlrich commented Apr 7, 2013

Noticed a hardcoded hyphen in the standard CategorizeEventsByStreamPath projection. Replaced it with the passed in separator.

@ysw
Copy link
Contributor

ysw commented Apr 7, 2013

It is not easy as changing this only place. The _separator in this class tells how to extract category from the stream id. You can configure it as projection arguments.

The $ce- prefix defines an index stream for a category. While I agree it is better to use a constant everywhere, changing it will break consumers of index streams that rely on this naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants