Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

replace hardcoded dash with _separator #41

Closed
wants to merge 1 commit into from

3 participants

Jonathan Yuriy Solodkyy Greg Young
Jonathan

Noticed a hardcoded hyphen in the standard CategorizeEventsByStreamPath projection. Replaced it with the passed in separator.

Yuriy Solodkyy
Collaborator
ysw commented

It is not easy as changing this only place. The _separator in this class tells how to extract category from the stream id. You can configure it as projection arguments.

The $ce- prefix defines an index stream for a category. While I agree it is better to use a constant everywhere, changing it will break consumers of index streams that rely on this naming convention.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 7, 2013
  1. Jonathan
This page is out of date. Refresh to see the latest.
2  src/EventStore/EventStore.Projections.Core/Standard/CategorizeEventsByStreamPath.cs
View
@@ -51,7 +51,7 @@ public CategorizeEventsByStreamPath(string source, Action<string> logger)
"Categorize stream projection handler has been initialized with separator: '{0}'", _separator));
}
// we will need to declare event types we are interested in
- _categoryStreamPrefix = "$ce-";
+ _categoryStreamPrefix = "$ce" + _separator;
}
public void ConfigureSourceProcessingStrategy(QuerySourceProcessingStrategyBuilder builder)
Something went wrong with that request. Please try again.