Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v3.3.0 #696

Merged
merged 1 commit into from Oct 5, 2015
Merged

Release v3.3.0 #696

merged 1 commit into from Oct 5, 2015

Conversation

riccardone
Copy link
Contributor

It's a long way to get this story fully complete. So maybe is better start with a first group of classes. I'll continue with all remaining pieces around the solution asap.

@pgermishuys
Copy link
Contributor

Hey @riccardone thank you so much for the contribution.
Would you mind squashing the commits. It's easier to review that way and easier to pull into release notes.
Thanks!

@riccardone
Copy link
Contributor Author

Yes, I can do that

2015-09-23 10:00 GMT+01:00 Pieter Germishuys notifications@github.com:

Hey @riccardone https://github.com/riccardone thank you so much for the
contribution.
Would you mind squashing the commits. It's easier to review that way and
easier to pull into release notes.

—
Reply to this email directly or view it on GitHub
#696 (comment)
.

@pgermishuys
Copy link
Contributor

Just saw this now @riccardone
I do apologise if it wasn't clear, would you mind squashing those commits into a single commit?

@riccardone
Copy link
Contributor Author

For future reference I've just used the following command to do the squash and set the first commit as pick and all others with the squash command
git rebase -i origin/release-v3.3.0~5 release-v3.3.0
and then pushed remotely
Let me know if it is not what you expect

@riccardone
implemented loggin on multiple lines for GossipController
06af654 
refactored first bunch of classes using multiple log calls instead of one

refactored multiple line logging in EventStore.ClusterNode.Program

refactored multi line log in EventStore.Transport.Tcp.TcpConnectionSsl DisplaySslStreamInfo

refactored multiple line logging in the following method EventStore.Core.GossipServiceBase LogClusterChange

refactored multiple line logging on EventStore.Core MasterReplicationService Handle(ReplicationMessage.ReplicaSubscriptionRequest
@jen20
Copy link
Contributor

jen20 commented Oct 5, 2015

Looks good to me. Thanks @riccardone!

jen20 added a commit that referenced this pull request Oct 5, 2015
@jen20
Merge pull request #696 from riccardone/release-v3.3.0
9d34e0e 
Separate multi-line log messages into individual log calls
@jen20 jen20 merged commit 9d34e0e into EventStore:release-v3.3.0 Oct 5, 2015
@pgermishuys pgermishuys mentioned this pull request Jun 10, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@riccardone @pgermishuys @jen20