Mean, Min, Max, Count global aggs for Expressions2 #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #684 +/- ##
==========================================
- Coverage 85.80% 85.25% -0.55%
==========================================
Files 140 134 -6
Lines 11823 11594 -229
==========================================
- Hits 10145 9885 -260
- Misses 1678 1709 +31
|
xcharleslin
changed the title
samster25
reviewed
Mar 13, 2023
jaychia
reviewed
Mar 14, 2023
| let field = expr.to_field(schema)?; | ||
| Ok(Field::new( | ||
| field.name.as_str(), | ||
| match &field.dtype { |
There was a problem hiding this comment.
We have a field.dtype.is_numeric() now that may be helpful here
There was a problem hiding this comment.
Thanks! There's some nonvacuous upcasting logic in the match though
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.