diff --git a/provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/ShadowCache.java b/provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/ShadowCache.java index af4d6812f3d..466cc90e20b 100644 --- a/provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/ShadowCache.java +++ b/provisioning/provisioning-impl/src/main/java/com/evolveum/midpoint/provisioning/impl/ShadowCache.java @@ -20,7 +20,6 @@ import com.evolveum.midpoint.common.refinery.RefinedObjectClassDefinition; import com.evolveum.midpoint.common.refinery.ShadowDiscriminatorObjectDelta; import com.evolveum.midpoint.prism.*; -import com.evolveum.midpoint.prism.Visitor; import com.evolveum.midpoint.prism.delta.*; import com.evolveum.midpoint.prism.match.MatchingRuleRegistry; import com.evolveum.midpoint.prism.path.IdItemPathSegment; @@ -78,7 +77,6 @@ import java.util.ArrayList; import java.util.Collection; import java.util.Collections; -import java.util.Comparator; import java.util.List; /** @@ -397,7 +395,7 @@ private PrismObject futurizeShadow(PrismObject shadow, PrismObject resultShadow = shadow; ShadowType resultShadowType = resultShadow.asObjectable(); List sortedOperations = sortOperations(resultShadowType.getPendingOperation()); - boolean resourceReadIsCachingOnly = resourceReadIsCahingOnly(resource); + boolean resourceReadIsCachingOnly = resourceReadIsCachingOnly(resource); for (PendingOperationType pendingOperation: sortedOperations) { OperationResultStatusType resultStatus = pendingOperation.getResultStatus(); if (resultStatus == OperationResultStatusType.FATAL_ERROR || resultStatus == OperationResultStatusType.NOT_APPLICABLE) { @@ -416,7 +414,7 @@ private PrismObject futurizeShadow(PrismObject shadow, ObjectDeltaType pendingDeltaType = pendingOperation.getDelta(); ObjectDelta pendingDelta = DeltaConvertor.createObjectDelta(pendingDeltaType, prismContext); if (pendingDelta.isAdd()) { - if (resultShadowType.isExists() == Boolean.FALSE) { + if (Boolean.FALSE.equals(resultShadowType.isExists())) { resultShadow = pendingDelta.getObjectToAdd().clone(); resultShadow.setOid(shadow.getOid()); resultShadowType = resultShadow.asObjectable(); @@ -443,13 +441,12 @@ private PrismObject futurizeShadow(PrismObject shadow, return resultShadow; } - private boolean resourceReadIsCahingOnly(ResourceType resource) { + private boolean resourceReadIsCachingOnly(ResourceType resource) { ReadCapabilityType readCapabilityType = ResourceTypeUtil.getEffectiveCapability(resource, ReadCapabilityType.class); - Boolean cachingOnly = readCapabilityType.isCachingOnly(); - if (cachingOnly == Boolean.TRUE) { - return true; + if (readCapabilityType == null) { + return false; // TODO reconsider this } - return false; + return Boolean.TRUE.equals(readCapabilityType.isCachingOnly()); } private boolean canReturnCachedAfterNotFoundOnResource(Collection> options, PrismObject repositoryShadow, ResourceType resource) throws ConfigurationException { @@ -468,7 +465,7 @@ private boolean canReturnCachedAfterNotFoundOnResource(Collection> options, PrismObject repositoryShadow, ResourceType resource) throws ConfigurationException { - if (resourceReadIsCahingOnly(resource)) { + if (resourceReadIsCachingOnly(resource)) { return true; } PointInTimeType pit = GetOperationOptions.getPointInTimeType(SelectorOptions.findRootOptions(options));