From 4018ce81d22560726f7fff59e29e662aabd43817 Mon Sep 17 00:00:00 2001
From: Radovan Semancik <radovan.semancik@evolveum.com>
Date: Tue, 7 Jul 2020 13:22:28 +0200
Subject: [PATCH] Report-related schema comments

---
 .../xml/ns/public/common/common-core-3.xsd         | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd b/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd
index 8be772f26ef..49ba81b8d24 100755
--- a/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd
+++ b/infra/schema/src/main/resources/xml/ns/public/common/common-core-3.xsd
@@ -23531,6 +23531,7 @@
                         </xsd:annotation>
                     </xsd:element>
 
+                    <!-- TODO: rename to fileFormat -->
                     <xsd:element name="export" type="tns:ExportConfigurationType" minOccurs="0">
                         <xsd:annotation>
                             <xsd:documentation>
@@ -23614,6 +23615,7 @@
         </xsd:restriction>
     </xsd:simpleType>
 
+    <!-- TODO: Rename to FileFormatConfigurationType -->
     <xsd:complexType name="ExportConfigurationType">
         <xsd:annotation>
             <xsd:documentation>
@@ -23660,6 +23662,7 @@
         </xsd:sequence>
     </xsd:complexType>
 
+    <!-- TODO: rename to FileFormatTypeType -->
     <xsd:simpleType name="ExportType">
         <xsd:annotation>
             <xsd:documentation>
@@ -24255,6 +24258,7 @@
         </xsd:complexContent>
     </xsd:complexType>
 
+    <!-- TODO: rename to ReportDataType -->
     <xsd:complexType name="ReportOutputType">
         <xsd:annotation>
             <xsd:documentation>
@@ -24265,7 +24269,9 @@
             <xsd:extension base="c:AssignmentHolderType">
                 <xsd:sequence>
                     <xsd:element name="filePath" type="xsd:string"/>
-                    <xsd:element name="exportType" type="tns:ExportType"/>
+                    <xsd:element name="exportType" type="tns:ExportType">
+                        <!-- TODO: rename to fileFormat -->
+                    </xsd:element>
                     <xsd:element name="reportRef" type="c:ObjectReferenceType">
                         <xsd:annotation>
                             <xsd:documentation>
@@ -25172,6 +25178,11 @@
                        </xsd:annotation>
                    </xsd:element>
                    <xsd:element ref="tns:documentation" minOccurs="0" maxOccurs="1"/>
+                   <!--
+                        TODO: we may need to add <type> here.
+                        E.g. if we want to specify that the CSV field that looks like string is in fact boolean.
+                        This can be also used by GUI, e.g. rendering checkbox instead of text input field.
+                        -->
                    <xsd:element name="path" type="t:ItemPathType" minOccurs="0">
                        <xsd:annotation>
                            <xsd:documentation>
@@ -25228,6 +25239,7 @@
                        </xsd:annotation>
                    </xsd:element>
                    <xsd:element name="expression" type="tns:ExpressionType" minOccurs="0" maxOccurs="1">
+                       <!-- TODO: change to import/expression and export/expression -->
                        <xsd:annotation>
                            <xsd:documentation>
                                <p>