From 41081cdf7ce0857923edc44d63f592154b9387a1 Mon Sep 17 00:00:00 2001 From: Viliam Repan Date: Sat, 26 Mar 2016 22:37:55 +0100 Subject: [PATCH] MID-2776 fixed storing debug list page search --- .../admin/configuration/PageDebugList.java | 12 +++++------ .../admin/configuration/PageDebugView.java | 2 +- .../web/page/admin/dto/ObjectViewDto.java | 20 +++++++++++++++++++ .../web/session/ConfigurationStorage.java | 4 ---- 4 files changed, 27 insertions(+), 11 deletions(-) diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugList.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugList.java index 6a28cecccb5..7fe94922bce 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugList.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugList.java @@ -160,10 +160,6 @@ public class PageDebugList extends PageAdminConfiguration { private IModel> resourcesModel; public PageDebugList() { - this(true); - } - - public PageDebugList(boolean clearPagingInSession) { searchModel = new LoadableModel(false) { @Override @@ -171,7 +167,11 @@ protected DebugSearchDto load() { ConfigurationStorage storage = getSessionStorage().getConfiguration(); DebugSearchDto dto = storage.getDebugSearchDto(); - setupSearchDto(dto); + if (dto == null) { + dto = new DebugSearchDto(); + dto.setType(ObjectTypes.SYSTEM_CONFIGURATION); + setupSearchDto(dto); + } return dto; } @@ -185,7 +185,7 @@ protected DebugConfDialogDto load() { } }; - resourcesModel = new LoadableModel>() { + resourcesModel = new LoadableModel>(false) { @Override protected List load() { diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugView.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugView.java index 7594e087b23..e7ac2526245 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugView.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/configuration/PageDebugView.java @@ -344,7 +344,7 @@ public void savePerformed(AjaxRequestTarget target) { target.add(getFeedbackPanel()); } else { showResult(result); - setResponsePage(new PageDebugList(false)); + setResponsePage(new PageDebugList()); } } } diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/dto/ObjectViewDto.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/dto/ObjectViewDto.java index c8b9e9516ac..427452a99b1 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/dto/ObjectViewDto.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/dto/ObjectViewDto.java @@ -21,6 +21,7 @@ import com.evolveum.midpoint.xml.ns._public.common.common_3.ObjectType; import java.io.Serializable; +import java.util.Arrays; /** * @author lazyman @@ -104,4 +105,23 @@ public Class getType() { public void setType(Class type) { this.type = type; } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + + ObjectViewDto that = (ObjectViewDto) o; + + if (oid != null ? !oid.equals(that.oid) : that.oid != null) return false; + if (name != null ? !name.equals(that.name) : that.name != null) return false; + if (xml != null ? !xml.equals(that.xml) : that.xml != null) return false; + if (object != null ? !object.equals(that.object) : that.object != null) return false; + return type != null ? type.equals(that.type) : that.type == null; + } + + @Override + public int hashCode() { + return Arrays.hashCode(new Object[]{oid, name, xml, object, type}); + } } diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/session/ConfigurationStorage.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/session/ConfigurationStorage.java index 1bcfdf2b4ab..eeed7106fdd 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/session/ConfigurationStorage.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/session/ConfigurationStorage.java @@ -36,10 +36,6 @@ public class ConfigurationStorage extends PageStorage { private ObjectPaging accountDetailsPaging; public DebugSearchDto getDebugSearchDto() { - if (debugSearchDto == null) { - debugSearchDto = new DebugSearchDto(); - debugSearchDto.setType(ObjectTypes.SYSTEM_CONFIGURATION); - } return debugSearchDto; }