From 7d2a95b1d41786bc5bec92d47faea9ae8a0f87ea Mon Sep 17 00:00:00 2001 From: lskublik Date: Tue, 2 Jun 2020 12:29:55 +0200 Subject: [PATCH] fix for exporting popup on AuditLogViewerPanel --- .../button/CsvDownloadButtonPanel.java | 9 +++++++++ .../web/component/dialog/ExportingPanel.java | 18 ++++++++++++++++++ .../reports/component/AuditLogViewerPanel.html | 2 +- .../reports/component/AuditLogViewerPanel.java | 8 +++++++- 4 files changed, 35 insertions(+), 2 deletions(-) diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/api/component/button/CsvDownloadButtonPanel.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/api/component/button/CsvDownloadButtonPanel.java index 16a0fff8ab0..70a9a9b6d1f 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/api/component/button/CsvDownloadButtonPanel.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/gui/api/component/button/CsvDownloadButtonPanel.java @@ -163,6 +163,11 @@ public void exportPerformed(AjaxRequestTarget target) { protected void createReportPerformed(String name, SearchFilterType filter, AjaxRequestTarget target) { CsvDownloadButtonPanel.this.createReportPerformed(name, filter, exportableColumnsIndex, target); } + + @Override + public boolean isVisibleCreateReportOption() { + return CsvDownloadButtonPanel.this.isVisibleCreateReportOption(); + } }; getPageBase().showMainPopup(exportingPanel, target); } @@ -185,4 +190,8 @@ protected void createReportPerformed(String name, SearchFilterType filter, AjaxR protected abstract void createReportPerformed(String name, SearchFilterType filter, List indexOfColumns, AjaxRequestTarget target); + public boolean isVisibleCreateReportOption() { + return true; + } + } diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java index 1c933b73f3e..0ccb309fe2c 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/component/dialog/ExportingPanel.java @@ -21,6 +21,7 @@ import com.evolveum.midpoint.web.component.message.FeedbackAlerts; import com.evolveum.midpoint.web.component.search.Search; +import com.evolveum.midpoint.web.component.util.VisibleEnableBehaviour; import com.evolveum.prism.xml.ns._public.query_3.SearchFilterType; import org.apache.wicket.Component; @@ -165,6 +166,12 @@ public void onClick(AjaxRequestTarget target) { ((PageBase) getPage()).hideMainPopup(target); } }; + createReport.add(new VisibleEnableBehaviour() { + @Override + public boolean isVisible() { + return isVisibleCreateReportOption(); + } + }); panel.add(createReport); AjaxButton exportSelected = new AjaxButton(ID_EXPORT, new StringResourceModel("ExportingPopupPanel.exportSelected", this, null)) { @@ -218,6 +225,8 @@ public WebMarkupContainer createPanel(String panelId) { return createTable(panelId, dataTable); } }); + + tabs.add(new PanelTab(getPageBase().createStringResource("ExportingPopupPanel.filter")) { @Override public WebMarkupContainer createPanel(String panelId) { @@ -228,6 +237,11 @@ public PageBase getPageBase() { } }; } + + @Override + public boolean isVisible() { + return isVisibleCreateReportOption(); + } }); return tabs; } @@ -364,4 +378,8 @@ public Component getComponent() { return this; } + public boolean isVisibleCreateReportOption() { + return true; + } + } diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.html b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.html index d82a79301a4..2165d24c85a 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.html +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.html @@ -60,7 +60,7 @@ -
+
diff --git a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java index 404da8ea937..068db238aaa 100644 --- a/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java +++ b/gui/admin-gui/src/main/java/com/evolveum/midpoint/web/page/admin/reports/component/AuditLogViewerPanel.java @@ -616,6 +616,11 @@ protected void createReportPerformed(String name, SearchFilterType filter, List< protected DataTable getDataTable() { return getAuditLogViewerTable().getDataTable(); } + + @Override + public boolean isVisibleCreateReportOption() { + return false; + } }; return exportDataLink; @@ -659,7 +664,8 @@ protected List> initColumns() { List> columns = new ArrayList<>(); IColumn linkColumn = new LinkColumn( createStringResource("AuditEventRecordType.timestamp"), AuditEventRecordProvider.TIMESTAMP_VALUE_PARAMETER, - AuditEventRecordProvider.TIMESTAMP_VALUE_PARAMETER) { + AuditEventRecordType.F_TIMESTAMP.getLocalPart()) { + private static final long serialVersionUID = 1L; @Override