From e2625a4bf8a9efa897ae2ca2c00e188e4df66c70 Mon Sep 17 00:00:00 2001 From: Richard Richter Date: Wed, 18 Mar 2020 00:33:56 +0100 Subject: [PATCH] MidpointTestMixin: footer indicates failure + exceptions logged as WARN --- .../midpoint/tools/testng/MidpointTestMixin.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tools/test-ng/src/main/java/com/evolveum/midpoint/tools/testng/MidpointTestMixin.java b/tools/test-ng/src/main/java/com/evolveum/midpoint/tools/testng/MidpointTestMixin.java index 23870f33f97..07ed8ee6f89 100644 --- a/tools/test-ng/src/main/java/com/evolveum/midpoint/tools/testng/MidpointTestMixin.java +++ b/tools/test-ng/src/main/java/com/evolveum/midpoint/tools/testng/MidpointTestMixin.java @@ -130,12 +130,15 @@ default void displayTestTitle(String testTitle) { */ default void displayTestFooter(String testTitle, ITestResult testResult) { if (testResult.getThrowable() != null) { - displayException(testTitle + " thrown unexpected exception", testResult.getThrowable()); + displayException(testTitle + " threw unexpected exception", testResult.getThrowable()); } long testMsDuration = testResult.getEndMillis() - testResult.getStartMillis(); - System.out.println(TEST_OUT_FOOTER_PREFIX + testTitle + " FINISHED in " + testMsDuration + " ms" + TEST_OUT_FOOTER_SUFFIX); - logger().info(TEST_LOG_PREFIX + testTitle + " FINISHED in " + testMsDuration + " ms" + TEST_LOG_SUFFIX); + String finishedLabel = testResult.isSuccess() + ? " FINISHED in " + : " FINISHED with FAILURE in "; + System.out.println(TEST_OUT_FOOTER_PREFIX + testTitle + finishedLabel + testMsDuration + " ms" + TEST_OUT_FOOTER_SUFFIX); + logger().info(TEST_LOG_PREFIX + testTitle + finishedLabel + testMsDuration + " ms" + TEST_LOG_SUFFIX); } default void display(String text) { @@ -158,7 +161,7 @@ default void displayValue(String title, Object value) { default void displayException(String title, Throwable e) { System.out.println(DISPLAY_OUT_PREFIX + title + ":"); e.printStackTrace(System.out); - logger().debug(DISPLAY_LOG_FORMAT1, title, e); + logger().warn(DISPLAY_LOG_FORMAT1, title, e); } /**