Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ConvertFrom-HtmlTable #1

Merged
merged 4 commits into from Oct 5, 2019

Conversation

@ThePoShWolf
Copy link
Contributor

ThePoShWolf commented Oct 4, 2019

As well as an example. This is using the AngleSharp library which was already included in the module.

@ThePoShWolf

This comment has been minimized.

Copy link
Contributor Author

ThePoShWolf commented Oct 4, 2019

Hey! I made another commit, I wasn't clear on everything you mentioned over Twitter DMs, so let me know what you think when you have some more time.

That's what I meant for changes ;-) 

1. Skip instead of SkipIndex to support 5.1
2. Moved Output to proper place
3. Added [ordered] to hash to keep order of columns. For small tables not a problem, for larger ones columns would be out of place.
Made it so it displays examples properly.
@PrzemyslawKlys

This comment has been minimized.

Copy link
Member

PrzemyslawKlys commented Oct 5, 2019

I've fixed a few things. Do you think it's ok now? :)

@ThePoShWolf

This comment has been minimized.

Copy link
Contributor Author

ThePoShWolf commented Oct 5, 2019

Looks good to me! All tests I had run before still return as expected. Thanks!

@PrzemyslawKlys PrzemyslawKlys merged commit 5d24cc8 into EvotecIT:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.