Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add networks card info #43 and #56 and guest user #88 #90

Merged
merged 1 commit into from Mar 6, 2020

Conversation

@itpro-tips
Copy link
Contributor

itpro-tips commented Mar 6, 2020

Use guest user instead of guest group #88
Fix some typo
Add network card infos related to loopback #43, DHCP #56 and WindowsFirewall Profile

Use guest user instead of guest group #88
Fix some typo
Add network card infos related to loopback #43, DHCP #56 and WindowsFirewall Profile
@PrzemyslawKlys

This comment has been minimized.

Copy link
Member

PrzemyslawKlys commented Mar 6, 2020

I wonder if DHCP vs STATIC is still true. Azure machines for DCs are mostly based on DHCP. If you touch network card it disconnects and requires a reboot.

@PrzemyslawKlys

This comment has been minimized.

Copy link
Member

PrzemyslawKlys commented Mar 6, 2020

And I wonder if this could be detected and ignored if anything or just relying on disabling test in such circumstances.

@itpro-tips

This comment has been minimized.

Copy link
Contributor Author

itpro-tips commented Mar 6, 2020

Yes you're right, in Azure they are mostly in DHCP.
AFAIK Azure instance metadata service can be used to identify Azure VM but maybe not simple to implement.

@PrzemyslawKlys

This comment has been minimized.

Copy link
Member

PrzemyslawKlys commented Mar 6, 2020

I'll turn off checking DHCP by default but will leave the test in there. This way anyone who wants to use it can, but I don't think it's required to use STATIC vs DHCP anymore.

@PrzemyslawKlys PrzemyslawKlys merged commit 323ece7 into EvotecIT:master Mar 6, 2020
@itpro-tips itpro-tips deleted the itpro-tips:branch1 branch Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.