[pull] main from commontoolsinc:main #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documents important patterns discovered during development: - Getting Cell access for mutation (Cell<> wrapper in Input) - Exposing actions via handlers for cross-charm calling - Consuming actions via Streams 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Tony Espinoza <tonyespinoza@Tonys-MacBook-Pro.local> Co-authored-by: Claude <noreply@anthropic.com>
… in a handler (#2172) * adding test reproducing the bug: pushing a newly created charm onto an array in a handler doesn't result in the runner charm being added. * fix: recipes from cells that are returned via recipe are now being instantiated: - Runner: When outputBinding is a direct link, use the existing cell instead of creating a new one and binding back. This ensures that when a recipe outputs to an existing cell, it writes directly to it. - Recipe: Add check to ensure `outputs` is not a Cell before iterating in `factoryFromRecipe`. - Cell: Fix `createRef` to use `this._frame.cause` for consistent ID generation. - Cell: Change `export` to use `getAsLink` for external cells, fixing potential serialization issues. - Tests: Update `recipes.test.ts` to verify `Cell<Array>.push` behavior with `asCell: true` and proper transaction handling. * Ensure recipes created in handlers are collected even if not returned - Track created opaque refs in the current frame in `opaqueRefWithCell`. - Update `Runner` to check for `frame.opaqueRefs` existence when deciding whether to process a result recipe in event handlers and actions. - This allows patterns created and attached via side effects (e.g., `list.push(newPattern)`) to be correctly instantiated without needing to be returned from the handler. - Updated `recipes.test.ts` to verify this behavior by removing the explicit return.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )