Paging is not working as it did previously for repeater with infinite scroll #1867

Closed
aheile opened this Issue Sep 20, 2016 · 4 comments

Projects

None yet

3 participants

@aheile
aheile commented Sep 20, 2016

With the latest fuelux update, our repeater is no longer paging data correctly. After the first page, the pageIndex is ending up NaN. After digging in further, it appears to be happening with this line:
https://github.com/ExactTarget/fuelux/blob/master/js/repeater.js#L254

renderItems() calls the callback() and so "d" is always undefined. If I remove "state.data = d;" then the paging works again.

function callAfterRender (d) {
    state.data = d;
    afterRender.call(self, state);
}

image

@cormacmccarthy

@cormacmccarthy
Contributor

@aheile can you try modifying that callback() line to say callback(data) and see if that fixes please? We are looking into the issue now, and, believe that will be the fix we put in place, but, want to make sure it actually fixes it for you.

@aheile
aheile commented Sep 21, 2016

@cormacmccarthy @swilliamset Thank you, yes, that fixes it.

@cormacmccarthy cormacmccarthy self-assigned this Sep 21, 2016
@cormacmccarthy cormacmccarthy added this to the 3.15.8 milestone Sep 21, 2016
@cormacmccarthy
Contributor

@aheile I have a PR open. Once it is merged in, we will do a release as soon as we can. In the meantime, feel free to manually implement the fix.

@chriscorwin chriscorwin closed this in #1869 Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment