New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for wizard to go RTL #1161

Merged
merged 2 commits into from May 21, 2015

Conversation

Projects
None yet
5 participants
@vernak2539
Contributor

vernak2539 commented Mar 6, 2015

fixes #1156.

All they have to do is add a class of "rtl" next to wizard. Example of markdown can be found here

@aziz1117

This comment has been minimized.

aziz1117 commented Mar 6, 2015

i try to write "RTL" next to "Wizard" but it still from Left to Right, could you please explain how to do that.

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 6, 2015

@aziz1117 without this being merged in it's a little tougher. Once this is merged, you can probably model your markdown after the example link in the original comment.

Otherwise, you can compile the diff in the LESS and add it to an extra stylesheet

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 12, 2015

@swilliamset @cormacmccarthy anyone have time to look at this? It's a pretty simple change, but has just been sitting here

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 12, 2015

wizard-rtl
Screenshot is just adding .rtl to .wizard based on your guidance above.

The content and the steps (name number, name number, etc) look correct but not 100% on what should be expected from the next/prev buttons.

Do we have requirements or a user story that we can sync with?

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 12, 2015

Nope, it was just a random thing after I saw that issue.

The buttons behaviours are mirrored exactly and I provided an example of
what the markup should be
On Thu, 12 Mar 2015 at 16:03 Stephen Williams notifications@github.com
wrote:

[image: wizard-rtl]
https://cloud.githubusercontent.com/assets/347227/6621872/74d792e0-c8af-11e4-9e79-e5f44b502510.png

The content and the steps (name number, name number, etc) look correct but
not 100% on what should be expected from the next/prev buttons.

Do we have requirements or a user story that we can sync with?


Reply to this email directly or view it on GitHub
#1161 (comment).

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 12, 2015

@swilliamset I don't think you're using the markdown example I put in the original comment. Please use that one, and it should be correct

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 12, 2015

@vernak2539 you are exactly right i took

All they have to do is add a class of "rtl"

to mean that was the only change to the markdown.

also i'm seeing some sensitivity in firefox where the content slides under the header. @vernak2539 can you reproduce?

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 12, 2015

I'll take a look in a bit

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 13, 2015

on resize or monitor change even it corrects itself :(

screen shot 2015-03-13 at 2 28 59 pm

@cormacmccarthy

This comment has been minimized.

Contributor

cormacmccarthy commented Mar 14, 2015

Do we control the fact that the next and prev arrows are pointed in the wrong direction, or is that something we expect users(developers) to "worry" about?

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 14, 2015

The markup needs to be moved as the link at the top shows. Already discussed with Alex. Will need to be well documented with the snippet provided.

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 16, 2015

@swilliamset I wasn't able to reproduce in firefox. Attached a screenshot. Tried resizing the window before and after loading to no avail.
wizard rtl

@cormacmccarthy cormacmccarthy added this to the 3.6.5 milestone Mar 17, 2015

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 30, 2015

I'm on 36.0.4. As mentioned in your about there is an update.

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 30, 2015

Damn, who thought two minor versions would make that happen. will look into it

@swilliamset

This comment has been minimized.

Member

swilliamset commented Mar 31, 2015

them be major version son!

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Mar 31, 2015

Shit, brain wasn't working. You're right
On Tue, 31 Mar 2015 at 15:35, Stephen Williams notifications@github.com
wrote:

them be major version son!


Reply to this email directly or view it on GitHub
#1161 (comment).

@interactivellama interactivellama modified the milestones: 3.7.0, 3.6.5 Apr 6, 2015

@swilliamset

This comment has been minimized.

Member

swilliamset commented Apr 10, 2015

@vernak2539 any updates on this?

@swilliamset swilliamset modified the milestones: 3.7.0, 3.8.0 Apr 10, 2015

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Apr 13, 2015

I haven't had the time. I'll try to get to it this week

Alex Vernacchia
@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented Apr 17, 2015

@swilliamset This is good to go.

screen shot 2015-04-17 at 1 35 37 pm

I've added a more detailed example gist here

swilliamset pushed a commit that referenced this pull request May 21, 2015

Stephen Williams
Merge pull request #1161 from vernak2539/GH1156-wizard-rtl
Allows for wizard to go RTL 🎉 🎈 🎉

@swilliamset swilliamset merged commit 2e34ba2 into ExactTarget:master May 21, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swilliamset

This comment has been minimized.

Member

swilliamset commented May 21, 2015

🎉 🎈 🎉 finally merged 🎉 🎈 🎉
thx @vernak2539

@vernak2539 vernak2539 deleted the vernak2539:GH1156-wizard-rtl branch May 21, 2015

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented May 22, 2015

👍

@vernak2539

This comment has been minimized.

Contributor

vernak2539 commented May 26, 2015

@swilliamset what release is this going into?

@swilliamset

This comment has been minimized.

Member

swilliamset commented May 26, 2015

@vernak2539
targeting 3.8.0

apologies for the delay but based on internal calendars we are reserving the next minor release until June 1st at the latest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment