Provides data object to repeater render callbacks #1869

Merged
merged 2 commits into from Sep 22, 2016

Projects

None yet

3 participants

@cormacmccarthy
Contributor
cormacmccarthy commented Sep 21, 2016 edited

When repeater completes rendering a callback is called, which in turn triggers the rendered.fu.repeater function. This callback needs to receive the data provided by the dataSource so that it can pass it along through the trigger.

I noticed when writing the unit tests that the search object was having the same event triggered on it, but, was not receiving any data. I am now passing along the data for consistency sake (and so that tests would pass since they were expecting it).

fixes #1867

To test:

  • pull changes
  • reset to 17dbe60
  • run unit tests grunt test (they should fail)
  • reset to 6894504
  • run unit tests grunt test (they should now pass)
  • runt grunt servefast
  • open http://localhost:8000/ and interact with repeaters (paging, etc) and make sure they still work.
  • review/comment on code
@cormacmccarthy cormacmccarthy added this to the 3.15.8 milestone Sep 21, 2016
@chriscorwin

SEEMS TO WORK

Unit tests seem to pass for the testing conditions they set.

@chriscorwin chriscorwin merged commit 7b15b88 into ExactTarget:master Sep 22, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cormacmccarthy cormacmccarthy deleted the cormacmccarthy:GH1867---paging-is-not-working-as-it-did-previously-for-repeater-with-infinite-scroll branch Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment