Replaces JS loader with SVG. Stubs out old JS methods #1890

Merged
merged 3 commits into from Oct 26, 2016

Projects

None yet

2 participants

@cormacmccarthy
Contributor
cormacmccarthy commented Oct 26, 2016 edited

Old:
image

New:
image

  • Pull changes
  • grunt servefast
  • Open http://localhost:8000/#loader
  • Make sure loader is working
  • Right click loader "inspect"
  • Make sure data- attribute on loader isn't firing repeatedly
  • Confirm there are no console errors related to loader
  • Review code
@cormacmccarthy cormacmccarthy added this to the 3.15.9 milestone Oct 26, 2016
@chriscorwin

✔️

@chriscorwin chriscorwin merged commit 6c271a1 into ExactTarget:master Oct 26, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@cormacmccarthy cormacmccarthy referenced this pull request Oct 26, 2016
Closed

Use MC Theme SVG for Loader #1884

3 of 3 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment