updates to qunit 2 #1894

Merged
merged 5 commits into from Nov 4, 2016

Projects

None yet

2 participants

@cormacmccarthy
Contributor
cormacmccarthy commented Oct 31, 2016 edited
  • pull down branch
  • delete node_modules
  • npm cache clean
  • npm install
  • bower install && bower update
  • grunt test
@cormacmccarthy cormacmccarthy added this to the 3.15.9 milestone Oct 31, 2016
@@ -1173,56 +1174,7 @@ label.fuelux .checkbox-inline {
font-size: 64px;
position: relative;
width: 64px;
-}
@swilliamset
swilliamset Nov 1, 2016 Member

is this branch based correctly? or have the loader changes not been merged yet?

@swilliamset swilliamset self-assigned this Nov 1, 2016
@swilliamset
Member

Submitting a PR to your PR branch to possible resolve the travis fail

@swilliamset swilliamset referenced this pull request in cormacmccarthy/fuelux Nov 2, 2016
Merged

add explicit QUnit.start to commonjs bundle test #1

@swilliamset
Member

Removing the commonjs
https://github.com/ExactTarget/fuelux/blob/master/grunt/config/qunit.js#L34
makes travis happy helping reduce the scope of the problem.

Now what is the solution?

@swilliamset swilliamset closed this Nov 4, 2016
@swilliamset swilliamset deleted the cormacmccarthy:GH1891---upgrade-to-qunit-2-to-support-mac-os-sierra branch Nov 4, 2016
@swilliamset swilliamset reopened this Nov 4, 2016
@swilliamset

reviewed it a couple times over now. travis is happy again.

@swilliamset swilliamset merged commit 4ea7e26 into ExactTarget:master Nov 4, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment