Datepicker w/ Moment parseDate parsing strings results in good date object not `Invalid Date` #1907

Merged
merged 3 commits into from Dec 10, 2016

Projects

None yet

3 participants

@swilliamset
Member

fixes #1906

Code made two attempts to parse but passed the failed result from the first attempt to the second attempt instead of the raw date string.

@futuremint futuremint self-requested a review Dec 8, 2016
@futuremint

Looks good to me! Thanks for adding the clarifying name to the tryMomentParseAll function.

@swilliamset
Member

@futuremint please sanity check now that i moved the dist build before the test.

@futuremint

Yep, should be find as long as browserify:commonjs is still first (its also required for the tests to run)

@swilliamset swilliamset merged commit e16f714 into ExactTarget:master Dec 10, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@swilliamset swilliamset deleted the swilliamset:datepicker-fix-for-parseDate-parsing-strings branch Dec 10, 2016
@cormacmccarthy cormacmccarthy added this to the 3.15.10 milestone Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment