Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Datepicker w/ Moment parseDate parsing strings results in good date object not Invalid Date #1907

Conversation

swilliamset
Copy link
Contributor

fixes #1906

Code made two attempts to parse but passed the failed result from the first attempt to the second attempt instead of the raw date string.

@futuremint futuremint self-requested a review December 8, 2016 21:26
Copy link
Contributor

@futuremint futuremint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for adding the clarifying name to the tryMomentParseAll function.

@swilliamset
Copy link
Contributor Author

@futuremint please sanity check now that i moved the dist build before the test.

Copy link
Contributor

@futuremint futuremint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, should be find as long as browserify:commonjs is still first (its also required for the tests to run)

@swilliamset swilliamset merged commit e16f714 into ExactTarget:master Dec 10, 2016
@swilliamset swilliamset deleted the datepicker-fix-for-parseDate-parsing-strings branch December 10, 2016 20:48
@cmcculloh-kr cmcculloh-kr added this to the 3.15.10 milestone Jan 5, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants