better commonjs test (clean dist, consistent test) #1910

Merged
merged 2 commits into from Dec 15, 2016

Projects

None yet

4 participants

@swilliamset
Member

fix #1909

  • removed commonjs testing resource (js/npm.js) from dist folder
  • buld dist task no longer leaves dist/js/npm.js in zip
  • moved creation of resources for commonjs into prep test task
  • test dist task now preps for commonjs tasks and cleans up
@swilliamset swilliamset assigned futuremint and unassigned futuremint Dec 10, 2016
@swilliamset swilliamset requested a review from futuremint Dec 10, 2016
@swilliamset swilliamset better commonjs test (clean dist, consistent test)
- removed commonjs testing resource (js/npm.js) from dist folder
- buld dist task no longer leaves dist/js/npm.js in zip
- moved creation of resources for commonjs into prep test task
- test dist task now preps for commonjs tasks and cleans up
341d2f8
@futuremint

Fix typo and I think it'll be good to go.

grunt/tasks/test.js
- ['browserify:commonjs', 'dist', 'jshint', 'connect:testServer', 'qunit:noMoment', 'qunit:globals', 'qunit:dist', 'htmllint', 'resetdist']);
+ ['jshint', 'connect:testServer', 'qunit:noMoment', 'qunit:globals', 'test-dist', 'htmllint']);
+
+ grunt.registerTask('prep-commonjs-test', 'run commonjs config buiild and browserify to prep for commonjs test',
@futuremint
futuremint Dec 15, 2016 Member

Typo in description buiild.

@@ -28,7 +28,7 @@ module.exports = function(grunt) {
// Full distribution task
grunt.registerTask('dist', 'Build "dist." Contributors: do not commit "dist."',
- ['clean:dist', 'distcss', 'copy:fonts', 'copy:templates', 'distjs', 'commonjs', 'distzip']);
+ ['clean:dist', 'distcss', 'copy:fonts', 'copy:templates', 'distjs', 'distzip']);
@futuremint
futuremint Dec 15, 2016 Member

Is the commonjs bundle used anywhere else in the dev stuff? Meaning... is it ok that we're removing it from dist completely and only running it during test?

@swilliamset
swilliamset Dec 15, 2016 Member

no it's not used elsewhere

@futuremint futuremint merged commit e8394ac into ExactTarget:master Dec 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vernak2539
Member

just wondering, if you're deleting it, will it be re-added during publishing?

https://github.com/ExactTarget/fuelux/blob/master/package.json#L74

@cormacmccarthy cormacmccarthy added this to the 3.15.10 milestone Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment