New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite the XLS SST parser #257

Closed
andersnm opened this Issue Jul 27, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@andersnm
Collaborator

andersnm commented Jul 27, 2017

The xls SST parser is currently one big 100 line function:

IMHO one of the last dark corners in the project :-) A rewrite should take the following into account:

  • According to the specs, the SST does not exist in BIFF2-5, only BIFF8, yet there is code to handle pre-BIFF8 SST strings. No tests fail if removing these bits.

  • Establish a better pattern for dealing with Continue records (also needed for #251): Read the continue records straight from the stream as needed (currently it's more complicated than it needs to be)

  • Simplify the IXlsString interface and all the string implementations. Do not need to be aware of implementation details of the SST.

@andersnm andersnm closed this in 329e3a9 Jul 28, 2017

@andersnm

This comment has been minimized.

Show comment
Hide comment
@andersnm

andersnm Jul 28, 2017

Collaborator

Fixed a bug with strings having >64k phonetic string data (ExtendedStringSize/ExtRst). There is no test for it yet.

Collaborator

andersnm commented Jul 28, 2017

Fixed a bug with strings having >64k phonetic string data (ExtendedStringSize/ExtRst). There is no test for it yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment