Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove `detectexternalip` #1092
Well, detecting external IP was always only part of the solution since it ignored ports and to check if they were forwarded and reachable. Which they aren't - in most of the home router cases. @erkarl 's docker solution will do both.
Anyhow, let's talk about Tor next Tuesday, which will do away with the whole IP address detection / port forwarding problem and I think should be default in future. That's why I believe IP detection shouldn't be an xud core feature anymore. And ... I didn't expect @michael1011 to be that fast.
(On-top TOR might solve our "full mesh network scalability problem", remind me to mention it!)
I think that if people are able to setup their router to forward their port, they will also be able to set their external IP in the config. The only case in which this feature would have made sense is when people don't have a static external IP which would result in having to set the IP again after every restart of their router. And that is kind of an edge case.
Anyways. Let's talk about Tor on next Tuesday and leave the PR alone until then.