Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
`xud`-level P2P reconnections are attempted from both sides #1135
Steps to reproduce
Connect two xud instances via manual connect on xud level. Restart both instances with e.g. network off and watch both instances trying to reconnect.
Only the connection initiator tries to reconnect
Both peers try to reconnect
referenced this issue
Aug 11, 2019
@kilrau Are both nodes being restarted at the same time? Consider the following situation:
I'm wondering what is the downside of having potentially two connection attempts in a case like this. The second one should fail gracefully due to the nodes already being connected, if not that seems like the real issue.
See my comments on #1145 for more details about my concerns.
Even though originally we did not intend to re-connect to advertised URIs we never connected to before, now with TOR this behavior is actually desirable (since probability of advertised URIs being reachable is high) and this improves reconnections as per @sangaman description above. No need to change anything.