Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscribing to single order stream is not working as a maker #1339

Open
erkarl opened this issue Nov 26, 2019 · 0 comments
Open

Subscribing to single order stream is not working as a maker #1339

erkarl opened this issue Nov 26, 2019 · 0 comments
Labels

Comments

@erkarl
Copy link
Collaborator

@erkarl erkarl commented Nov 26, 2019

The optional --stream parameter for placing the order is only working as a taker.

After looking at the codebase it is not trivial to fix because of the mechanics of the flow of onUpdate callback: https://github.com/ExchangeUnion/xud/blob/master/lib/orderbook/OrderBook.ts#L524

The current workaround is to subscribe to events from all orders instead.

@erkarl erkarl added bug P3 labels Nov 26, 2019
@kilrau kilrau added this to To do in 1.0.0-beta.2 via automation Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
1.0.0-beta.2
  
To do
1 participant
You can’t perform that action at this time.