New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved buy/sell output for xucli #620

Closed
kilrau opened this Issue Oct 30, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@kilrau
Contributor

kilrau commented Oct 30, 2018

As per #612 (comment) we aim for the following output format:

xucli buy 0.0005 LTC/BTC market --stream

market order accepted
matched with peer order : .......
attempting swap: .....
swap failed: .....
peer order removed from book: .....
attempting swap with: .....
swap failed: .....
peer order removed from book: .....
attempting swap with: .....
swap failed: .....
no more matches found
quitting.

Successful case:

xucli buy 0.0005 LTC/BTC market --stream

market order accepted
matched with peer order : .......
attempting swap: .....
swap succeeded: .....
done.

@kilrau kilrau added this to the 1.0.0-alpha.3 milestone Oct 30, 2018

@kilrau kilrau referenced this issue Oct 30, 2018

Closed

Trading issue #612

@kilrau kilrau modified the milestones: 1.0.0-alpha.4, 1.0.0-alpha.3 Oct 30, 2018

@sangaman sangaman changed the title from Improved Swap outputs on CLI & Stream to Improved buy/sell output for xucli Oct 30, 2018

@sangaman sangaman removed the grpc label Oct 30, 2018

@sangaman sangaman self-assigned this Oct 30, 2018

@sangaman

This comment has been minimized.

Collaborator

sangaman commented Oct 30, 2018

This is an extension of #558, and a prerequisite is #609. I'll work on these since it seems like it'd be fairly helpful for our testing and simnet setup.

@kilrau

This comment has been minimized.

Contributor

kilrau commented Oct 30, 2018

  1. CLI will use output from grpc stream
  2. placeOrder (buy/sell) SYNC: keep current events, add swap failure event -> @sangaman make sure only meaningful (results) events are in the SYNC response
@sangaman

This comment has been minimized.

Collaborator

sangaman commented Oct 31, 2018

Per our discussion on the weekly call I'm thinking of leaving out the "attempting swap" event because it does not exist on our grpc call. Maybe that could be for a future enhancement although I don't think it's really necessary as it has little to no value for anything but the cli, and even for the cli it is just cosmetic.

@kilrau kilrau added the top priority label Nov 5, 2018

@kilrau kilrau modified the milestones: 1.0.0-alpha.3, 1.0.0-alpha.4 Nov 6, 2018

sangaman added a commit that referenced this issue Nov 13, 2018

feat(cli): format buy & sell output
This attempts to make the cli output for the `buy` and `sell` commands
more human-readable and succint.

Closes #620.

sangaman added a commit that referenced this issue Nov 13, 2018

feat(cli): format buy & sell output
This attempts to make the cli output for the `buy` and `sell` commands
more human-readable and succint.

Closes #620.

sangaman added a commit that referenced this issue Nov 16, 2018

feat(cli): format buy & sell output
This attempts to make the cli output for the `buy` and `sell` commands
more human-readable and succint.

Closes #620.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment