New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare database for #608 and #562 #621

Closed
kilrau opened this Issue Oct 30, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@kilrau
Contributor

kilrau commented Oct 30, 2018

This prepares the database to support #562 & #608 so we don't have breaking changes later

@kilrau kilrau added the database label Oct 30, 2018

@kilrau kilrau added this to the 1.0.0-alpha.2 milestone Oct 30, 2018

sangaman added a commit that referenced this issue Oct 31, 2018

feat(db): add Order and Trade models
This commit creates new database models for orders and trades. The
`Order` model is used to persist all data related to a specific order,
whereas the `Trade` model will be used for persisting data about
completed trades. Some order-specific properties from `SwapDeal` have
moved to the `Order` model. Rather than repeat that data for each
`SwapDeal` instance that swaps the same order, which results in data
duplication and creates the possibility for inconsistencies, swaps
for the same order now point to the same `Order` instance.

This also attempts to add all known associations between models for
easy join queries via the Sequelize API going forward.

Closes #621.

@wafflebot wafflebot bot added the in progress label Oct 31, 2018

sangaman added a commit that referenced this issue Oct 31, 2018

feat(db): add Order and Trade models
This commit creates new database models for orders and trades. The
`Order` model is used to persist all data related to a specific order,
whereas the `Trade` model will be used for persisting data about
completed trades. Some order-specific properties from `SwapDeal` have
moved to the `Order` model. Rather than repeat that data for each
`SwapDeal` instance that swaps the same order, which results in data
duplication and creates the possibility for inconsistencies, swaps
for the same order now point to the same `Order` instance.

This also attempts to add all known associations between models for
easy join queries via the Sequelize API going forward.

Closes #621.

sangaman added a commit that referenced this issue Oct 31, 2018

feat(db): add Order and Trade models
This commit creates new database models for orders and trades. The
`Order` model is used to persist all data related to a specific order,
whereas the `Trade` model will be used for persisting data about
completed trades. Some order-specific properties from `SwapDeal` have
moved to the `Order` model. Rather than repeat that data for each
`SwapDeal` instance that swaps the same order, which results in data
duplication and creates the possibility for inconsistencies, swaps
for the same order now point to the same `Order` instance.

This also attempts to add all known associations between models for
easy join queries via the Sequelize API going forward.

Closes #621.

sangaman added a commit that referenced this issue Oct 31, 2018

feat(db): add Order and Trade models
This commit creates new database models for orders and trades. The
`Order` model is used to persist all data related to a specific order,
whereas the `Trade` model will be used for persisting data about
completed trades. Some order-specific properties from `SwapDeal` have
moved to the `Order` model. Rather than repeat that data for each
`SwapDeal` instance that swaps the same order, which results in data
duplication and creates the possibility for inconsistencies, swaps
for the same order now point to the same `Order` instance.

This also attempts to add all known associations between models for
easy join queries via the Sequelize API going forward.

Closes #621.

@kilrau kilrau modified the milestones: 1.0.0-alpha.2, 1.0.0-alpha.3 Nov 1, 2018

sangaman added a commit that referenced this issue Nov 9, 2018

feat(db): add Order and Trade models
This commit creates new database models for orders and trades. The
`Order` model is used to persist all data related to a specific order,
whereas the `Trade` model will be used for persisting data about
completed trades. Some order-specific properties from `SwapDeal` have
moved to the `Order` model. Rather than repeat that data for each
`SwapDeal` instance that swaps the same order, which results in data
duplication and creates the possibility for inconsistencies, swaps
for the same order now point to the same `Order` instance.

This also attempts to add all known associations between models for
easy join queries via the Sequelize API going forward.

Closes #621.

@sangaman sangaman closed this in #623 Nov 9, 2018

@wafflebot wafflebot bot removed the in progress label Nov 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment