Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Limit Order FOK / IOC #622
I suggest to support FOK & IOC with limit orders.
with getorders I see a peer order that I wish to take.
The matching with the peer order failed for some reason (peer order does not exists anymore, swap failed, etc), As a result my take order entered the book and broadcasted to all my peers. This was not my intention.
changed the title from
Suggestion: limit order with FOK (fill or kill)
[Concept] Limit Order with FOK (fill or kill)
Oct 31, 2018
CLI UX Example FOK:
CLI example IOC:
FOK can be tricky with XUD. To properly support it we need all the swaps to use the same preimage and the taker should release the preimage only if and when he got the payment from the maker for all the swaps initiated by taker. IOC and AON can be easier to implement. We can redefine FOK in a way that it must be matched with a single maker order. This may create a situation in which the match will not be done with the best price order.…
On Sun, Nov 18, 2018 at 11:26 AM Kilian Rausch
Why the same preImage can't be used for multiple makers? Should not be a problem since we have a single taker and multiple makers.
Oh I didn't realize that FOK also requires the entire order to be filled - or none of it (I guess I was talking about IOC, that should be easy). That is more complicated than I'd said, but I think it can be done as offer described. I don't see a problem either with the taker using the same preimage for multiple swaps/makers - the makers won't even have to know about it. Although I think we have a check on the maker side to not allow reuse of preimages that we may need to relax.