Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defensive coding to avoid 0x80000000/0xFFFFFFFF FPE #1751

Merged
merged 1 commit into from
Jun 30, 2021

Conversation

kevinbackhouse
Copy link
Collaborator

This is a follow-up to #1750. Adding the same defensive code against FPEs caused by 0x80000000/0xFFFFFFFF. This code is new on the main branch.

@codecov
Copy link

codecov bot commented Jun 30, 2021

Codecov Report

Merging #1751 (e4f5684) into main (695d22c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1751   +/-   ##
=======================================
  Coverage   66.94%   66.94%           
=======================================
  Files         151      151           
  Lines       20794    20794           
=======================================
  Hits        13920    13920           
  Misses       6874     6874           
Impacted Files Coverage Δ
src/tags_int.cpp 87.20% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 695d22c...e4f5684. Read the comment docs.

Copy link
Member

@hassec hassec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hassec hassec merged commit 8c4d67c into Exiv2:main Jun 30, 2021
@kevinbackhouse kevinbackhouse added this to the v1.00 milestone Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants