Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure that read is complete to prevent infinite loop #1788

Merged

Conversation

kevinbackhouse
Copy link
Collaborator

Fixes: GHSA-9jh3-fcc3-g6hv

The problem is that an incomplete read on line 639 can cause the code to get confused about its position in the file, leading to an infinite loop. The fix is to check that the read is compelte.

This function has at least one other bug which I will fix in a separate pull request.

@kevinbackhouse kevinbackhouse added this to the v0.27.5 milestone Jul 17, 2021
@kevinbackhouse kevinbackhouse added bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify labels Jul 17, 2021
src/jpgimage.cpp Outdated Show resolved Hide resolved
@kevinbackhouse kevinbackhouse merged commit e931c0a into Exiv2:0.27-maintenance Jul 25, 2021
6 checks passed
kevinbackhouse added a commit that referenced this pull request Jul 25, 2021
Make sure that read is complete to prevent infinite loop (backport #1788)
@kevinbackhouse kevinbackhouse deleted the Fix-GHSA-9jh3-fcc3-g6hv branch July 26, 2021 11:56
@clanmills clanmills mentioned this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug forward-to-main Forward changes in a 0.28.x PR to main with Mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants