New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid negative integer overflow when chunkLength == 0 #794
Avoid negative integer overflow when chunkLength == 0 #794
Conversation
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #794 +/- ##
====================================================
+ Coverage 62.67% 62.68% +<.01%
====================================================
Files 156 156
Lines 21543 21545 +2
====================================================
+ Hits 13503 13505 +2
Misses 8040 8040
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
43d1868
to
f6cca78
Compare
c9078ac
to
3259224
Compare
|
Thanks for the contribution! LGTM. Would you mind to rebase the branch in top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for your contribution!
3259224
to
6f49df2
Compare
Pull request has been modified.
|
@kevinbackhouse I've rebased the changes in your branch on top of |
6f49df2
to
206c357
Compare
|
@piponazo @kevinbackhouse any objections to merging this? |
Fixes #789.