-
Notifications
You must be signed in to change notification settings - Fork 290
Issue 841: replace assert with enforce. #842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 841: replace assert with enforce. #842
Conversation
01f9f35 to
c97ac5a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave it to Dan and Luis to approve. Dan brought enforce() into the code-base.
I believe you're in Oxford. You're very welcome to come to Camberley for a BBQ during the summer. We're going to Scotland and other short trips in the next couple of months. After that, it'd be nice to meet up.
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #842 +/- ##
====================================================
+ Coverage 62.71% 62.72% +<.01%
====================================================
Files 156 156
Lines 21568 21566 -2
====================================================
Hits 13527 13527
+ Misses 8041 8039 -2
Continue to review full report at Codecov.
|
|
I've grep'ed the source code for invocations of |
|
@D4N: that sounds fine to me. Would you like me to add that to this PR? |
c97ac5a to
1a5fa3f
Compare
|
I think @D4N 's idea is very nice. If you could try to throw inside |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this!
|
@kevinbackhouse Could you rebase the commints on top of 0.27-maintenance and squast them into one? |
d939ae3 to
7eeb638
Compare
Pull request has been modified.
(cherry picked from commit 7798ae2)
(cherry picked from commit 7798ae2)
(cherry picked from commit 7798ae2)
Fixes #841.