Add bounds check on allocation size #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 0.27-maintenance #846 +/- ##
====================================================
+ Coverage 62.71% 62.71% +<.01%
====================================================
Files 156 156
Lines 21558 21567 +9
====================================================
+ Hits 13520 13526 +6
- Misses 8038 8041 +3
Continue to review full report at Codecov.
|
piponazo
reviewed
May 13, 2019
src/pngchunk_int.cpp
Outdated
|
|
||
| long length = (long) atol(startOfLength); | ||
| enforce(length >= 0, Exiv2::kerCorruptedMetadata); |
There was a problem hiding this comment.
Could we merge these 2 conditions into a single call to enforce ? I am fine if you prefer to leave it as it is.
kevinbackhouse
force-pushed
the
afl_bugfixes_pngchunk
branch
from
683407d
to
bcaca80
Compare
piponazo
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #845.
The main issue is the unchecked value of
lengthat pngchunk_int.cpp:669. But I have also fixed some minor issues where*spwas read before the check thatsp < eot.