Introduce About Fragment#128
Merged
Merged
Conversation
Contributor
Author
|
The |
Contributor
|
Request changes:
|
Contributor
|
On smartphone in mode landscape, we don't see privacy policy string |
- Also migrate to new lint block Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Signed-off-by: Aayush Gupta <aayushgupta219@gmail.com>
Contributor
|
Ok for me, i have tested changes:
|
|
Ok for me, tested on OnePlus 5T+ Lineageos 18.1 (Android 11)
|
ghost
approved these changes
Feb 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR:
This should close #111, however, keep in mind that the URL seems not hosted or public yet and should be handled as well.
The URL can be changed by maintainers by editing the variable value in
app/src/main/java/org/eu/exodus_privacy/exodusprivacy/fragments/AboutFragment.java