feat: support batching operations together #11
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the problem
set/delete are currently per-key, and result in the entire file being written
solution
a batch api lets the caller maintain a kind of queue, and flush all writes at the end
the main problem will probably be solved by https://github.com/ExodusMovement/exodus-desktop/pull/8034 and https://github.com/ExodusMovement/exodus-desktop/pull/8035 but it would still be nice to be able to batch ops together and save time on writes
the below is what i get on restore
on masterwith batching added on top of master (ignore the times, the blue numbers are the batch sizes):when running on top of the PRs linked above, it's way better, but might still be worth it in case we have bursts: