DNRY: add .flush() method #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 2, 2020 12:11
mvayngrib
reviewed
Jul 2, 2020
mvayngrib
reviewed
Jul 2, 2020
Co-authored-by: Mark Vayngrib <mvayngrib@gmail.com>
Co-authored-by: Mark Vayngrib <mvayngrib@gmail.com>
|
Thanks @mvayngrib ! |
Merged
|
@kklash Still needed? |
|
@RyanZim Probably not 100% necessary but it seems like a good refactor for simplification if you'd like me to do it |
|
Doesn't matter to me. Debatable if it should be a public method, though. |
|
@kklash should we close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplifies the duplicated pattern of writing the seco-keyval instance to disk in one tidy async method.