Skip to content

fix: annotate fields with out-of-scope unions #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

fix: annotate fields with out-of-scope unions #12

merged 1 commit into from
Mar 14, 2024

Conversation

@danadajian
Copy link
Collaborator

@danadajian danadajian commented Mar 14, 2024 •
edited
Loading

📝 Description

  • We should never end up with a generated class where the field type is an annotation class. This actually prevents setting a value of one of the union member types, so such a field should have type Any with the documentational annotation class above it.

@danadajian danadajian requested a review from a team as a code owner March 14, 2024 16:45
@danadajian danadajian merged commit b50dafb into main Mar 14, 2024
@danadajian danadajian deleted the fix-out-of-scope-unions branch March 14, 2024 17:08
@github-actions
Copy link

github-actions bot commented Mar 14, 2024

🎉 This PR is included in version 1.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danadajian