Skip to content

Conversation

@smyrick
Copy link
Contributor

@smyrick smyrick commented Jan 29, 2019

If a class was named SearchInput, we would map that to SearchInputInput. If devs are specifically naming it an input we should not duplicate the string

smyrick added 2 commits January 29, 2019 08:32
If a class was named SearchInput, we would map that to SearchInputInput. If devs are specifically naming it an input we should not duplicate the string
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #157 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage     96.79%   96.79%           
  Complexity      152      152           
=========================================
  Files            53       53           
  Lines           499      499           
  Branches        100      100           
=========================================
  Hits            483      483           
  Misses            4        4           
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...a/graphql/generator/extensions/kClassExtensions.kt 100% <100%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 429d5e9...bfe2d34. Read the comment docs.

@dariuszkuc dariuszkuc merged commit 361ec8f into ExpediaGroup:master Jan 29, 2019
@smyrick smyrick deleted the input-suffix branch January 29, 2019 17:55
@smyrick smyrick added the changes: minor Changes require a minor version label Jan 29, 2019
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
* feat: do not append duplicate suffix

If a class was named SearchInput, we would map that to SearchInputInput. If devs are specifically naming it an input we should not duplicate the string

* test: move test function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: minor Changes require a minor version

Development

Successfully merging this pull request may close these issues.

2 participants