Skip to content

Conversation

@smyrick
Copy link
Contributor

@smyrick smyrick commented Feb 1, 2019

To prepare for subscriptions, I moved the order of the parameters in toSchema() so that config is first. This will allow us to easily add subscriptions as the optional final parameter. Also since we will have another option for a top level name I combined all the names into a single object

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #160 into master will decrease coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master    #160      +/-   ##
===========================================
- Coverage     96.79%   96.6%   -0.19%     
+ Complexity      152     151       -1     
===========================================
  Files            53      53              
  Lines           499     501       +2     
  Branches        100     100              
===========================================
+ Hits            483     484       +1     
  Misses            4       4              
- Partials         12      13       +1
Impacted Files Coverage Δ Complexity Δ
src/main/kotlin/com/expedia/graphql/toSchema.kt 100% <ø> (ø) 0 <0> (ø) ⬇️
...xpedia/graphql/generator/types/QueryTypeBuilder.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
...dia/graphql/generator/types/MutationTypeBuilder.kt 100% <100%> (ø) 6 <0> (ø) ⬇️
...otlin/com/expedia/graphql/SchemaGeneratorConfig.kt 100% <100%> (ø) 5 <1> (-1) ⬇️
...pedia/graphql/generator/types/ObjectTypeBuilder.kt 94.11% <0%> (-5.89%) 2% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46d9a7...4e1692a. Read the comment docs.

@smyrick smyrick added the changes: major Changes require a major version label Feb 2, 2019
@dariuszkuc dariuszkuc merged commit 218c997 into ExpediaGroup:master Feb 13, 2019
@smyrick smyrick deleted the config branch February 13, 2019 17:10
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: major Changes require a major version

Development

Successfully merging this pull request may close these issues.

2 participants