Skip to content

Conversation

@smyrick
Copy link
Contributor

@smyrick smyrick commented Feb 2, 2019

The new exception reads as following

com.expedia.graphql.exceptions.CouldNotCastArgumentException: Could not cast or map arguments in the data fetcher for parameter #1 items of fun com.expedia.graphql.execution.FunctionDataFetcherTest.MyClass.printList(kotlin.collections.List<kotlin.String>): kotlin.String

Also I added unit tests for the function data fetcher

@smyrick smyrick added the changes: minor Changes require a minor version label Feb 2, 2019
@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #161 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #161      +/-   ##
============================================
+ Coverage     96.79%   96.82%   +0.03%     
- Complexity      152      153       +1     
============================================
  Files            53       54       +1     
  Lines           499      504       +5     
  Branches        100      100              
============================================
+ Hits            483      488       +5     
  Misses            4        4              
  Partials         12       12
Impacted Files Coverage Δ Complexity Δ
...dia/graphql/generator/types/FunctionTypeBuilder.kt 85.18% <100%> (ø) 11 <0> (ø) ⬇️
...m/expedia/graphql/execution/FunctionDataFetcher.kt 77.77% <100%> (+2.77%) 9 <0> (ø) ⬇️
...raphql/exceptions/CouldNotCastArgumentException.kt 100% <100%> (ø) 1 <1> (?)
...aphql/exceptions/InvalidInputFieldTypeException.kt 100% <100%> (ø) 1 <1> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a46d9a7...7517565. Read the comment docs.

@smyrick smyrick merged commit 9f7cc7a into ExpediaGroup:master Feb 12, 2019
@smyrick smyrick deleted the list-inputs branch February 12, 2019 18:57
dariuszkuc pushed a commit to dariuszkuc/graphql-kotlin that referenced this pull request Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changes: minor Changes require a minor version

Development

Successfully merging this pull request may close these issues.

2 participants