Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tests for com.hotels.shunting.yard.common.messaging.Message #30

Merged

Conversation

@paulkennethkent
Copy link
Contributor

commented Mar 19, 2019

I've analysed your code base and noticed that shunting.yard.common.messaging.Message is not fully tested.

I've written some tests for the functions in this class with the help of Diffblue Cover. Hopefully, these tests should help you detect any regressions caused by future code changes. If you would find it useful to have additional tests written for this repository, I would be more than happy to look at other particular classes that you consider important.

@coveralls

This comment has been minimized.

Copy link

commented Mar 19, 2019

Pull Request Test Coverage Report for Build 273

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.9%) to 76.141%

Totals Coverage Status
Change from base Build 268: 2.9%
Covered Lines: 801
Relevant Lines: 1052

💛 - Coveralls

@paulkennethkent paulkennethkent force-pushed the Diffblue-benchmarks:add-unit-tests branch 2 times, most recently from 6c3a6c0 to 5ee61d7 Mar 19, 2019

Added tests for com.hotels.shunting.yard.common.messaging.Message
These tests were written using Diffblue Cover.

@paulkennethkent paulkennethkent force-pushed the Diffblue-benchmarks:add-unit-tests branch from 5ee61d7 to 406f0ed Mar 19, 2019

@paulkennethkent

This comment has been minimized.

Copy link
Contributor Author

commented Mar 20, 2019

Thanks for the feedback @AnanaMJ and @massdosage, I've made the changes you requested.

If you have any other projects or classes you would like me to have a look at then please let me know.

massdosage added some commits Mar 22, 2019

@massdosage
Copy link
Contributor

left a comment

I've made some changes which I think are more in line with what @AnanaMJ was suggesting in her comments. @abhimanyugupta07 if you're OK with these please merge. @paulkennethkent thanks for the contribution! You asked if we had any other projects which could benefit from an increase in coverage and we most certainly do - HotelsDotCom/mutant-swarm#7 relates to a project we just released that could definitely benefit from increased coverage (since it's a coverage tool!)

@abhimanyugupta07 abhimanyugupta07 merged commit 3ed57d0 into ExpediaGroup:master Mar 25, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.