Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: STREAMP-9751: ensure deletes are processed #335

Merged
merged 2 commits into from
Sep 21, 2023
Merged

fix: STREAMP-9751: ensure deletes are processed #335

merged 2 commits into from
Sep 21, 2023

Conversation

jamespfaulkner
Copy link
Contributor

stream-registry PR

Ensure that deletes are actually processed. Don't just ignore the CompletableFuture.

Changed

  • DefaultRepository::delete will wait until deletes have actually been processed before returning control to the caller.

PR Checklist Forms

  • CHANGELOG.md updated
  • Reviewer assigned
  • PR assigned (presumably to submitter)
  • Labels added (enhancement, bug, documentation)

@jamespfaulkner jamespfaulkner merged commit 375398c into master Sep 21, 2023
2 checks passed
@jamespfaulkner jamespfaulkner deleted the fix/STREAMP-9751/ensure_deletes_are_processed branch September 21, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andykruth-ii andykruth-ii andykruth-ii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamespfaulkner @andykruth-ii