diff --git a/CHANGELOG.md b/CHANGELOG.md index 2eb802ee7..9c9d0a1e5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,11 @@ ## [3.11.3] - TBD +### Fixed +- Exclude Junit5 dependencies as they clashed with Junit4 and caused maven to stop running the tests. +- Fixed metric(graphite) integration test (was broken since 3.10.12 (spring-boot upgrade). ### Changed - Exclude jetty-all from core module, because it makes spring start fail and makes `WaggleDanceIntegrationTest` fail. +- Upgrade maven.surefire.plugin.version to 3.1.2 (was 3.0.0-m5). +- Exclude jdk.tools clashes with > java8 JDK. ## [3.11.2] - 2023-07-04 ### Changed diff --git a/pom.xml b/pom.xml index 31871e341..139a4e203 100644 --- a/pom.xml +++ b/pom.xml @@ -1,4 +1,5 @@ - + 4.0.0 @@ -35,6 +36,7 @@ 2.5.3 + 3.1.2 2.7.11 2.10.1 2.2 @@ -183,6 +185,26 @@ pom import + + org.springframework.boot + spring-boot-starter-test + ${spring-boot.version} + test + + + org.mockito + * + + + org.hamcrest + * + + + org.junit.jupiter + junit-jupiter + + + org.apache.hadoop hadoop-common @@ -244,7 +266,7 @@ ${hcommon-hive-metastore.version} + listing them all here so we get one version deployed --> com.fasterxml.jackson.core jackson-databind diff --git a/waggle-dance-core/pom.xml b/waggle-dance-core/pom.xml index 1e5254c5a..8c22c5177 100644 --- a/waggle-dance-core/pom.xml +++ b/waggle-dance-core/pom.xml @@ -189,7 +189,11 @@ org.pentaho pentaho-aggdesigner-algorithm - + + + jdk.tools + jdk.tools + @@ -309,16 +313,6 @@ org.springframework.boot spring-boot-starter-test test - - - org.mockito - * - - - org.hamcrest - * - - org.hamcrest diff --git a/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java b/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java index 074e0bfa0..166bba7f7 100644 --- a/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java +++ b/waggle-dance-core/src/main/java/com/hotels/bdp/waggledance/metrics/MonitoredAspect.java @@ -1,5 +1,5 @@ /** - * Copyright (C) 2016-2019 Expedia, Inc. + * Copyright (C) 2016-2023 Expedia, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. diff --git a/waggle-dance-integration-tests/pom.xml b/waggle-dance-integration-tests/pom.xml index 51ef11ca5..5d8a60988 100644 --- a/waggle-dance-integration-tests/pom.xml +++ b/waggle-dance-integration-tests/pom.xml @@ -174,6 +174,5 @@ ${feign.version} test - - + diff --git a/waggle-dance-integration-tests/src/test/java/com/hotels/bdp/waggledance/WaggleDanceIntegrationTest.java b/waggle-dance-integration-tests/src/test/java/com/hotels/bdp/waggledance/WaggleDanceIntegrationTest.java index a00b74c67..67f36e6c3 100644 --- a/waggle-dance-integration-tests/src/test/java/com/hotels/bdp/waggledance/WaggleDanceIntegrationTest.java +++ b/waggle-dance-integration-tests/src/test/java/com/hotels/bdp/waggledance/WaggleDanceIntegrationTest.java @@ -1,5 +1,5 @@ /** - * Copyright (C) 2016-2022 Expedia, Inc. + * Copyright (C) 2016-2023 Expedia, Inc. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -390,17 +390,17 @@ public void typicalWithGraphite() throws Exception { Set metrics = new TreeSet<>(Arrays.asList(new String(graphite.getOutput()).split("\n"))); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_all_databases.all.calls.count 2"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_all_databases.all.calls;metricattribute=count 2"); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_all_databases.all.success.count 2"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_all_databases.all.success;metricattribute=count 2"); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.primary.calls.count 1"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.primary.calls;metricattribute=count 1"); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.primary.success.count 1"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.primary.success;metricattribute=count 1"); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.remote.calls.count 1"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.remote.calls;metricattribute=count 1"); assertMetric(metrics, - "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.remote.success.count 1"); + "graphitePrefix.counter.com.hotels.bdp.waggledance.server.FederatedHMSHandler.get_table_req.remote.success;metricattribute=count 1"); } private void assertMetric(Set metrics, String partialMetric) { diff --git a/waggle-dance-integration-tests/src/test/resources/log4j.xml b/waggle-dance-integration-tests/src/test/resources/log4j.xml new file mode 100644 index 000000000..ea289a5ca --- /dev/null +++ b/waggle-dance-integration-tests/src/test/resources/log4j.xml @@ -0,0 +1,64 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + \ No newline at end of file diff --git a/waggle-dance/src/main/resources/log4j2.xml b/waggle-dance/src/main/resources/log4j2.xml index 135ba10c0..51708a3d4 100644 --- a/waggle-dance/src/main/resources/log4j2.xml +++ b/waggle-dance/src/main/resources/log4j2.xml @@ -1,6 +1,6 @@