[$250] QBO-If "Export company card expenses as" is set to "Vendor bill", Locations toggle is locked

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5027294
Issue reported by: Applause - Internal Team

Action Performed:

1. Launch app
2. Go to workspace settings
3. Connect QBO
4. Tap export
5. Set export company card expense to "vendor bills"
6. Set export out of pocket expense to "journal entry"
7. Navite to import
8. Tap locations -- import

Expected Result:

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle must not be locked

Actual Result:

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle is locked

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6622536_1727898934788.Screenrecorder-2024-10-03-01-15-29-585_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021843661642289072627
• Upwork Job ID: 1843661642289072627
• Last Price Increase: 2024-10-15

Issue Owner

Current Issue Owner: @shubham1206agra

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If "Export company card expenses as" is set to "Vendor bill", the Locations toggle is locked

What is the root cause of that problem?

• The condition canImportLocation is incorrect:

App/src/pages/workspace/accounting/qbo/import/QuickbooksLocationsPage.tsx

Lines 25 to 27 in f475642

	const canImportLocation =
	qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY &&
	qboConfig?.nonReimbursableExpensesExportDestination !== CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL;

What changes do you think we should make in order to solve the problem?

• It should be:

    const canImportLocation =
        qboConfig?.reimbursableExpensesExportDestination === CONST.QUICKBOOKS_REIMBURSABLE_ACCOUNT_TYPE.JOURNAL_ENTRY &&
        qboConfig?.nonReimbursableExpensesExportDestination === CONST.QUICKBOOKS_NON_REIMBURSABLE_EXPORT_ACCOUNT_TYPE.VENDOR_BILL;

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021843661642289072627

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)