From 923896bbad6bd081d65ac0cd580ab6845930ac0b Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Tue, 21 Apr 2026 23:47:23 +0800 Subject: [PATCH 1/4] skip columns filter --- src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx b/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx index 50b8617c4439..8227fe025624 100644 --- a/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx +++ b/src/components/Search/SearchPageHeader/useSearchFiltersBar.tsx @@ -60,6 +60,7 @@ const SKIPPED_FILTERS = new Set([ FILTER_KEYS.VIEW, FILTER_KEYS.PAYER, FILTER_KEYS.ACTION, + FILTER_KEYS.COLUMNS, ]); function getFilterSentryLabel(filterKey: SearchAdvancedFiltersKey | SearchFilterKey | ReportFieldKey) { From ae88c1b693c173ef32b28aad50d5b357c58bc369 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Tue, 21 Apr 2026 23:47:38 +0800 Subject: [PATCH 2/4] show applied displays --- src/libs/SearchUIUtils.ts | 1 - src/pages/Search/SearchSavePage.tsx | 56 ++++++++++++++++++++++++++++- 2 files changed, 55 insertions(+), 2 deletions(-) diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index d0130d2a52f7..293ef2ca07e8 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -4741,7 +4741,6 @@ const FILTER_LABEL_MAP: Partial, queryJSON: SearchQueryJSON | undefined, translate: LocalizedTranslate) { + const appliedDisplays = []; + if (searchAdvancedFiltersForm.groupBy) { + appliedDisplays.push({label: translate('search.display.groupBy'), value: translate(`search.filters.groupBy.${searchAdvancedFiltersForm.groupBy}`)}); + } + + if (searchAdvancedFiltersForm.groupCurrency) { + appliedDisplays.push({label: translate('common.groupCurrency'), value: searchAdvancedFiltersForm.groupCurrency}); + } + + if (searchAdvancedFiltersForm.limit) { + appliedDisplays.push({label: translate('search.filters.limit'), value: searchAdvancedFiltersForm.limit}); + } + + if (searchAdvancedFiltersForm.view) { + appliedDisplays.push({label: translate('search.view.label'), value: translate(`search.view.${searchAdvancedFiltersForm.view}`)}); + } + + if (queryJSON?.sortBy) { + appliedDisplays.push({label: translate('search.display.sortBy'), value: translate(getSearchColumnTranslationKey(queryJSON.sortBy))}); + } + + if (queryJSON?.sortOrder) { + appliedDisplays.push({label: translate('search.display.sortOrder'), value: translate(`search.filters.sortOrder.${queryJSON.sortOrder}`)}); + } + + if (searchAdvancedFiltersForm.columns) { + appliedDisplays.push({label: translate('search.columns'), value: searchAdvancedFiltersForm.columns?.map((column) => translate(getSearchColumnTranslationKey(column))).join(', ')}); + } + + return appliedDisplays; +} + function SearchSavePage() { const styles = useThemeStyles(); const {translate, localeCompare} = useLocalize(); @@ -109,6 +144,7 @@ function SearchSavePage() { }; const appliedFilters = mapFiltersFormToLabelValueList(searchAdvancedFiltersForm, undefined, undefined, translate, localeCompare); + const appliedDisplays = getAppliedDisplays(searchAdvancedFiltersForm, currentSearchQueryJSON, translate); const {inputCallbackRef} = useAutoFocusInput(); @@ -157,6 +193,24 @@ function SearchSavePage() { ) : ( {translate('common.none')} )} + + {translate('search.display.label')}: + {appliedDisplays.length > 0 ? ( + appliedDisplays.map((filter) => ( + + {CONST.DOT_SEPARATOR} + + {filter.label}: + {filter.value} + + + )) + ) : ( + {translate('common.none')} + )} ); From 33609ea025e3204eda8c7d22ddd2eaa4447e2bfe Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Wed, 22 Apr 2026 00:08:40 +0800 Subject: [PATCH 3/4] only show columns when the length is > 0 --- src/pages/Search/SearchSavePage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/Search/SearchSavePage.tsx b/src/pages/Search/SearchSavePage.tsx index a84484f3123d..16e267f35d75 100644 --- a/src/pages/Search/SearchSavePage.tsx +++ b/src/pages/Search/SearchSavePage.tsx @@ -117,7 +117,7 @@ function getAppliedDisplays(searchAdvancedFiltersForm: Partial translate(getSearchColumnTranslationKey(column))).join(', ')}); } From 4ccde7f1f552da433622fe78a8b4fc166c566eb1 Mon Sep 17 00:00:00 2001 From: Bernhard Owen Josephus Date: Thu, 23 Apr 2026 21:57:09 +0800 Subject: [PATCH 4/4] lint --- src/pages/Search/SearchSavePage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/Search/SearchSavePage.tsx b/src/pages/Search/SearchSavePage.tsx index 16e267f35d75..9b60e0fffcc7 100644 --- a/src/pages/Search/SearchSavePage.tsx +++ b/src/pages/Search/SearchSavePage.tsx @@ -117,7 +117,7 @@ function getAppliedDisplays(searchAdvancedFiltersForm: Partial translate(getSearchColumnTranslationKey(column))).join(', ')}); }