From d8a08debca97eaec37705c24372b09c16a15bd98 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 12:12:31 +0200 Subject: [PATCH 1/8] no period in you appear offline --- src/languages/en.js | 2 +- src/languages/es.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/languages/en.js b/src/languages/en.js index f3c028c8a5d..e798c673a57 100755 --- a/src/languages/en.js +++ b/src/languages/en.js @@ -105,7 +105,7 @@ export default { leaveRoom: 'Leave room', your: 'your', conciergeHelp: 'Please reach out to Concierge for help.', - youAppearToBeOffline: 'You appear to be offline.', + youAppearToBeOffline: 'You appear to be offline', thisFeatureRequiresInternet: 'This feature requires an active internet connection to be used.', }, attachmentPicker: { diff --git a/src/languages/es.js b/src/languages/es.js index f968c28ac22..b4e0d9edfbf 100644 --- a/src/languages/es.js +++ b/src/languages/es.js @@ -105,7 +105,7 @@ export default { leaveRoom: 'Salir de la sala de chat', your: 'tu', conciergeHelp: 'Por favor contacta con Concierge para obtener ayuda.', - youAppearToBeOffline: 'Parece que estás desconectado.', + youAppearToBeOffline: 'Parece que estás desconectado', thisFeatureRequiresInternet: 'Esta función requiere una conexión a Internet activa para ser utilizada.', }, attachmentPicker: { From 2390abac4b85d7bc9efd0c96d6576d0197345123 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 12:13:11 +0200 Subject: [PATCH 2/8] use a new vairable size instead of hard code --- src/components/FullPageOfflineBlockingView.js | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/components/FullPageOfflineBlockingView.js b/src/components/FullPageOfflineBlockingView.js index 5c738bef98c..5aa0b1d32aa 100644 --- a/src/components/FullPageOfflineBlockingView.js +++ b/src/components/FullPageOfflineBlockingView.js @@ -10,6 +10,7 @@ import * as Expensicons from './Icon/Expensicons'; import themeColors from '../styles/themes/default'; import styles from '../styles/styles'; import compose from '../libs/compose'; +import variables from '../styles/variables'; const propTypes = { /** Child elements */ @@ -31,8 +32,8 @@ const FullPageOfflineBlockingView = (props) => { {props.translate('common.youAppearToBeOffline')} {props.translate('common.thisFeatureRequiresInternet')} From 423ea9b8001018441f67e19be6f3667695bbe860 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 12:13:18 +0200 Subject: [PATCH 3/8] make that variable --- src/styles/variables.js | 1 + 1 file changed, 1 insertion(+) diff --git a/src/styles/variables.js b/src/styles/variables.js index 7259a678443..0702c8ed7e8 100644 --- a/src/styles/variables.js +++ b/src/styles/variables.js @@ -36,6 +36,7 @@ export default { iconSizeLarge: 24, iconSizeXLarge: 28, iconSizeExtraLarge: 40, + iconSizeMondo: 60, emojiSize: 20, iouAmountTextSize: 40, mobileResponsiveWidthBreakpoint: 800, From 39811d5c87d12e882775f6f4b2c4bf4af39a21cf Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 12:13:33 +0200 Subject: [PATCH 4/8] margin top on text --- src/components/FullPageOfflineBlockingView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/FullPageOfflineBlockingView.js b/src/components/FullPageOfflineBlockingView.js index 5aa0b1d32aa..97396c9a0a6 100644 --- a/src/components/FullPageOfflineBlockingView.js +++ b/src/components/FullPageOfflineBlockingView.js @@ -35,7 +35,7 @@ const FullPageOfflineBlockingView = (props) => { width={variables.iconSizeMondo} height={variables.iconSizeMondo} /> - {props.translate('common.youAppearToBeOffline')} + {props.translate('common.youAppearToBeOffline')} {props.translate('common.thisFeatureRequiresInternet')} ); From edbbc01e6a2aa69cf390e6a5df8cbc36ed77d91e Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 20:34:01 +0200 Subject: [PATCH 5/8] change font size --- src/components/FullPageOfflineBlockingView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/FullPageOfflineBlockingView.js b/src/components/FullPageOfflineBlockingView.js index 97396c9a0a6..a5e9aaf303c 100644 --- a/src/components/FullPageOfflineBlockingView.js +++ b/src/components/FullPageOfflineBlockingView.js @@ -35,7 +35,7 @@ const FullPageOfflineBlockingView = (props) => { width={variables.iconSizeMondo} height={variables.iconSizeMondo} /> - {props.translate('common.youAppearToBeOffline')} + {props.translate('common.youAppearToBeOffline')} {props.translate('common.thisFeatureRequiresInternet')} ); From b7f07a290d8a205eb7ca169d606dcb00cfe39144 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 20:46:12 +0200 Subject: [PATCH 6/8] new svg --- assets/images/offline-cloud.svg | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/assets/images/offline-cloud.svg b/assets/images/offline-cloud.svg index d7dea203756..38cf2892e9c 100644 --- a/assets/images/offline-cloud.svg +++ b/assets/images/offline-cloud.svg @@ -1,5 +1,8 @@ - - - - + + + + + + From 0068d7c1fe6e040b72ef9b12465d05c4350cc2c1 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Wed, 1 Jun 2022 20:49:50 +0200 Subject: [PATCH 7/8] fix text size conflict --- src/components/FullPageOfflineBlockingView.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/FullPageOfflineBlockingView.js b/src/components/FullPageOfflineBlockingView.js index a5e9aaf303c..d9e059c7dfa 100644 --- a/src/components/FullPageOfflineBlockingView.js +++ b/src/components/FullPageOfflineBlockingView.js @@ -35,7 +35,7 @@ const FullPageOfflineBlockingView = (props) => { width={variables.iconSizeMondo} height={variables.iconSizeMondo} /> - {props.translate('common.youAppearToBeOffline')} + {props.translate('common.youAppearToBeOffline')} {props.translate('common.thisFeatureRequiresInternet')} ); From 0ca720c93424fba7628dc409fd03555ba1c45c05 Mon Sep 17 00:00:00 2001 From: Luke Donahue Date: Thu, 2 Jun 2022 12:30:21 +0200 Subject: [PATCH 8/8] changed icon variable name --- src/components/FullPageOfflineBlockingView.js | 4 ++-- src/styles/variables.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/components/FullPageOfflineBlockingView.js b/src/components/FullPageOfflineBlockingView.js index d9e059c7dfa..46af2cc4cfd 100644 --- a/src/components/FullPageOfflineBlockingView.js +++ b/src/components/FullPageOfflineBlockingView.js @@ -32,8 +32,8 @@ const FullPageOfflineBlockingView = (props) => { {props.translate('common.youAppearToBeOffline')} {props.translate('common.thisFeatureRequiresInternet')} diff --git a/src/styles/variables.js b/src/styles/variables.js index 0702c8ed7e8..b9fd2e260ea 100644 --- a/src/styles/variables.js +++ b/src/styles/variables.js @@ -36,7 +36,7 @@ export default { iconSizeLarge: 24, iconSizeXLarge: 28, iconSizeExtraLarge: 40, - iconSizeMondo: 60, + iconSizeSuperLarge: 60, emojiSize: 20, iouAmountTextSize: 40, mobileResponsiveWidthBreakpoint: 800,