New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile on Fedora 26 #320

Open
stephancb opened this Issue Nov 4, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@stephancb

stephancb commented Nov 4, 2017

Bedrock does not compile on Fedora 26 (and there is no compiled rpm). The problem seems to be that Fedora 26 ships only with g++-7 /c++-17, and the Bedrock code seems not compatible with this new standard.

@jgmdev

This comment has been minimized.

Show comment
Hide comment
@jgmdev

jgmdev Feb 7, 2018

I fixed the issues related to gcc7 on the archlinux PKGBUILD by patching the sources as follows:

sed -i "s|#include <atomic>|#include <atomic>\n#include <functional>|" \
  libstuff/libstuff.h

sed -i "s|/mbedtls/include -Werror -Wno-unu|/mbedtls/include -Wno-unu|" \
  Makefile

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp

jgmdev commented Feb 7, 2018

I fixed the issues related to gcc7 on the archlinux PKGBUILD by patching the sources as follows:

sed -i "s|#include <atomic>|#include <atomic>\n#include <functional>|" \
  libstuff/libstuff.h

sed -i "s|/mbedtls/include -Werror -Wno-unu|/mbedtls/include -Wno-unu|" \
  Makefile

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp
@jgmdev

This comment has been minimized.

Show comment
Hide comment
@jgmdev

jgmdev Feb 9, 2018

I just noticed this one:

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp

Is only needed on arm (at leat armv7h in my case), in x64 it should compile without it

jgmdev commented Feb 9, 2018

I just noticed this one:

sed -i 's|"Timestamp"), 1ul)|"Timestamp"), 1ull)|' \
  libstuff/STCPNode.cpp

Is only needed on arm (at leat armv7h in my case), in x64 it should compile without it

@wmertens

This comment has been minimized.

Show comment
Hide comment
@wmertens

wmertens Aug 15, 2018

Should these patches not be added @quinthar?

wmertens commented Aug 15, 2018

Should these patches not be added @quinthar?

@quinthar

This comment has been minimized.

Show comment
Hide comment
@quinthar

quinthar Aug 15, 2018

Contributor

Ah, sounds great! Can you or @jgmdev submit a PR? Thanks!

Contributor

quinthar commented Aug 15, 2018

Ah, sounds great! Can you or @jgmdev submit a PR? Thanks!

@wmertens

This comment has been minimized.

Show comment
Hide comment
@wmertens

wmertens Aug 15, 2018

wmertens commented Aug 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment